Gatsby V4, optimizations, and progress on spanish translation#318
Gatsby V4, optimizations, and progress on spanish translation#318
Conversation
…site � Conflicts: � content/tutorials/text/2d-array/index.es.mdx � i18n/react-intl/en.json � src/components/character/Donate.js � src/pages/index.js
…site � Conflicts: � package-lock.json � package.json � src/components/Topbar.js � src/pages/404.js � src/pages/index.js � src/pages/libraries.js � src/pages/reference.js
� Conflicts: � content/tutorials/text/2darray/index.es.mdx
� Conflicts: � content/tools/archive-sketch/archive-sketch.es.json
� Conflicts: � content/examples/Basics/Arrays/Array/Array.es.json � content/examples/Basics/Arrays/Array/Array.es.pde � content/examples/Basics/Control/Conditionals1/Conditionals1.es.json � content/examples/Topics/Fractals and L-Systems/PenroseSnowflake/PenroseSnowflake.es.json
|
Thanks @runemadsen for the detailed instructions! I have tried your branch locally and everything seems to run fine as far as I can tell. Are there specific tests you would like me to run? |
|
Great! As long as you have gone through all the major sections on the website (which I also did), and it looks good, I think we're good to go! |
|
Hey @runemadsen I found one thing that looks broken: images in the "Environment" part don't seem to load. This is the same in the English and Spanish versions. node version: v16.17.0.
|
|
Thanks for this! I can't replicate it on my own machine. Can you try running |
That did it! I have another question: you wrote that the Spanish version is disabled but the menu does appear when I run the website locally and I can switch to Spanish with the incomplete translation. Is this content supposed to be hidden? |
|
Great! About the spanish translation: I had forgotten to remove the config. I just pushed a fix to remove it, so you should be able to pull and the language selector should be gone after a restart. |
|
Thanks @runemadsen! I did a last test and everything looks good. Merged and will do a new release of the website today as there have been quite a few changes since last week :) |
|
Excellent! Keep me posted on how it goes! |


This PR turned into quite the upgrade for the code of the website. There should be no changes in design or content, but a number of improvements have been made:
3to4, which should make the build process a lot faster and the local development experience nicer.12in the GitHub Actions. The repo now has a.nvmrcfile stating the Node version, and the GitHub Actions have been upgraded to use same version: Node16.namefield in every node to not include thelocale, which makes the logic easier on many of the pages when it comes to translations.useTranslationsanduseTranslationsWithEnglishBase. They are both documented and used on some pages. As we get ready to publish the first real translation, they might be used even more.useFilteredArrayhook.pngfile instead of thejsonfile in the example folder, and this would lead to an error when trying to read the JSON. This has been fixed and the site should build now.@SableRaf This is a rather large pull request, and I have tested it as much as I can. If you could give it a good look on your local computer, that would make me feel a lot better. Here are the steps for making it run:
nvmfor this.node_modulesfoldernpm installnpm run devLet me know if you run into any issues!
This fixes #317